feat: make ground electrode location optional #94#151
Open
Manimaran-tech wants to merge 1 commit intoINCF:mainfrom
Open
feat: make ground electrode location optional #94#151Manimaran-tech wants to merge 1 commit intoINCF:mainfrom
Manimaran-tech wants to merge 1 commit intoINCF:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
This PR introduces a change to the acquisition schema to make the "location of the ground electrode" question optional.
Changes:
Added a new ground_electrode_exists item ("Was a ground electrode used?").
Updated
acquisition_schema.jsonld
to include this new item.
Modified the visibility logic for location_ground: it now depends on ground_electrode_exists == 1 instead of directly on online_reference_exists. This ensures users are first asked if a ground electrode was used before being asked for its location.
Verification:
Verified that the new item appears in the schema order.
Verified that the visibility logic mirrors the behavior of the reference electrode questions.