Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge/User: Improve toggling hidden badges in public profile #8846

Open
wants to merge 1 commit into
base: release_10
Choose a base branch
from

Conversation

mjansenDatabay
Copy link
Contributor

See: https://mantis.ilias.de/view.php?id=43589

If approved, this has to be picket to trunk.

@mjansenDatabay mjansenDatabay added bugfix improvement php Pull requests that update Php code labels Jan 14, 2025
@mjansenDatabay mjansenDatabay self-assigned this Jan 14, 2025
@mjansenDatabay
Copy link
Contributor Author

@kergomard A review of the changes in "User" is highly appreciated. Of course it is still ugly that the "Badge" component has to ...

  1. Modify a template in the "User" component
  2. Add PHP code to ilPublicUserProfileGUI

But as long as the public profile did not offer any kind of "Slot System" for other compoents, this PR at least ...

  • Fixes the linked issue
  • Removes depenencies on "jQuery"
  • Moves the JS code from the HTML template to an ES6 class

@mjansenDatabay mjansenDatabay force-pushed the hotfix/10/43589 branch 3 times, most recently from b82015d to ef4e076 Compare January 14, 2025 19:59
@mjansenDatabay mjansenDatabay added the javascript Pull requests that update Javascript code label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix improvement javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants