T&A: Ghost Attempts & correct detection of unfinished test passes

[lukas-heinrich]

Hi everyone,

with this PR, I propose a change to correctly recognize unfinished test attempts. Originally this is a fix for 28447, but I was able to find some other places that should be fixed with this change:

• https://mantis.ilias.de/view.php?id=42856
• https://mantis.ilias.de/view.php?id=27077
• Incorrect number of test attempts in the results view
• Blank test results in the detailed test view and man scoring
  

Reproduction

To reproduce the behavior, make sure that the test has at least the following settings:

• Overview of Answers Given: checked
• Set Time Limit for Completing Test > Maximum Time Available: e.g. 1 min
• Set Time Limit for Completing Test > Reset Time Limit for All Test Attempts: checked

Cause of the behavior

• The fundamental problem is that when resetting the Processing Time, the pass is incremented by one (\ilObjTest::isExecutable)
• This is why self::_getPass($active_id) returns a pass that doesn't exist
• When finishing the attempt via the button or cron job, the pass is incremented again (see \ilTestPassFinishTasks::performFinishTasks)

Tests

To verify this change, I tested the following scenarios and checked whether the number of passes and the unfinished passes are shown as expected.

• Attempt completed
• Attempt not completed
• First attempt completed, second attempt completed
• First attempt completed, second attempt not completed

I ran these four cases both for a test without a time limit and for a test with a limit, both with and without a reset. I also checked the database to see if there are any ghost passes.

I am looking forward to your feedback and comments. This PR was internally reviewed by @thojou .
Best,
@lukas-heinrich

[lukas-heinrich]

The branch is now updated and works for the release_9 branch.