Skip to content

Timespan component #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shreeyash07 wants to merge 15 commits into
base: project/early-action-protocols
Choose a base branch
from
Open

Timespan component #2100

shreeyash07 wants to merge 15 commits into from

Conversation

@shreeyash07
Copy link
Collaborator

@shreeyash07 shreeyash07 commented Nov 17, 2025 •
edited
Loading

Summary

Timespan Input component for the EAP

Changes

  • Add TimespanInput for EAP form

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1251d9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 force-pushed the project/early-action-protocols branch from dc47211 to d46e199 Compare November 17, 2025 10:12
@shreeyash07 shreeyash07 force-pushed the feature/timespan-component branch from 9c54bb0 to ba9353a Compare November 18, 2025 06:22
barshathakuri
barshathakuri requested changes Nov 19, 2025
View reviewed changes
app/src/components/TimespanInput/index.tsx Outdated
<>
<SelectInput
name="timeframe"
label="Timeframe"
Copy link
Collaborator

@barshathakuri barshathakuri Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the label Time frame

barshathakuri
barshathakuri requested changes Nov 20, 2025
View reviewed changes
app/src/components/TimespanInput/index.tsx Outdated
/>
<Checklist
name="timespan"
label="Time span"
Copy link
Collaborator

@barshathakuri barshathakuri Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add string translation.

@shreeyash07 shreeyash07 force-pushed the feature/timespan-component branch from d9efcae to 3b86ec7 Compare November 20, 2025 09:00
tnagorra
tnagorra requested changes Nov 21, 2025
View reviewed changes
app/src/components/TimespanInput/index.tsx
Comment on lines +65 to +68
export interface TimespanInputValue {
timeframe?: Timeframe;
timespan?: number[];
}
Copy link
Member

@tnagorra tnagorra Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of value does not match the type accepted by the backend.

@frozenhelium frozenhelium force-pushed the project/early-action-protocols branch 3 times, most recently from 9125185 to 9bd3e1a Compare November 25, 2025 06:29
@frozenhelium frozenhelium force-pushed the project/early-action-protocols branch 2 times, most recently from 2690280 to f860ae1 Compare December 10, 2025 18:17
@frozenhelium frozenhelium force-pushed the project/early-action-protocols branch 2 times, most recently from d10a0db to 5ccc1bc Compare December 11, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnagorra tnagorra tnagorra requested changes

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

@barshathakuri barshathakuri Awaiting requested review from barshathakuri

Assignees

@frozenhelium frozenhelium

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shreeyash07 @tnagorra @barshathakuri @frozenhelium