Add alert subscription API #2600
Draft
+405
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudip-khanal
changed the title
sudip-khanal
force-pushed
the
feat/add-alert-subscription-api
branch
2 times, most recently
from
bc2af82 to
2b2a505
Compare
sudip-khanal
force-pushed
the
feat/add-alert-subscription-api
branch
from
2b2a505 to
9916905
Compare
susilnem
requested changes
Dec 11, 2025
notifications/models.py
Outdated
| created_at = models.DateTimeField(auto_now_add=True, verbose_name=_("Created At")) | ||
| updated_at = models.DateTimeField(auto_now=True, verbose_name=_("Updated At")) | ||
| # Typing | ||
| id = int |
Member
There was a problem hiding this comment.
Suggested change
| id = int | |
| id: int |
notifications/models.py
Outdated
| verbose_name_plural = _("Alert Subscriptions") | ||
|
|
||
| def __str__(self): | ||
| return f"Alert subscription for {self.user}" |
Member
There was a problem hiding this comment.
Suggested change
| return f"Alert subscription for {self.user}" | |
| return f"Alert subscription for {self.user.full_name}" |
notifications/serializers.py
Outdated
|
|
||
| class HazardTypeSerializer(ModelSerializer): | ||
|
|
||
| type_display = serializers.CharField(source="get_alert_type_display", read_only=True) |
Member
There was a problem hiding this comment.
Suggested change
| type_display = serializers.CharField(source="get_alert_type_display", read_only=True) | |
| type_display = serializers.CharField(source="get_type_display", read_only=True) |
notifications/admin.py
Outdated
| class AlertSubscriptionAdmin(admin.ModelAdmin): | ||
| list_select_related = True | ||
| list_display = ("user", "created_at") | ||
| autocomplete_fields = ("user",) |
Member
There was a problem hiding this comment.
Suggested change
| autocomplete_fields = ("user",) | |
| autocomplete_fields = ("user","regions", "countries", "hazard_types") |
notifications/drf_views.py
Outdated
Comment on lines
119
to
123
| viewsets.GenericViewSet, | ||
| mixins.ListModelMixin, | ||
| mixins.RetrieveModelMixin, | ||
| mixins.CreateModelMixin, | ||
| mixins.UpdateModelMixin, |
Member
There was a problem hiding this comment.
We might need to delete the subscriptions.
Suggested change
| viewsets.GenericViewSet, | |
| mixins.ListModelMixin, | |
| mixins.RetrieveModelMixin, | |
| mixins.CreateModelMixin, | |
| mixins.UpdateModelMixin, | |
| viewsets.ModelVewset, |
notifications/tests.py
Outdated
| self.user1 = UserFactory.create(email="testuser1@com") | ||
| self.user2 = UserFactory.create(email="testuser2@com") | ||
|
|
||
| self.region = RegionFactory.create(name=2) |
Member
There was a problem hiding this comment.
Suggested change
| self.region = RegionFactory.create(name=2) | |
| self.region = RegionFactory.create(name=RegionName.ASIA_PACIFIC) |
sudip-khanal
force-pushed
the
feat/add-alert-subscription-api
branch
from
bd47752 to
b5abcec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.