Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release automation #401

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Prepare release automation #401

merged 5 commits into from
Aug 21, 2024

Conversation

kadler
Copy link
Member

@kadler kadler commented Aug 21, 2024

  • Refactor and clean up GitHub Actions workflows to automatically create and publish a release upon tag creation
  • Add automation for building the IBM i binaries using Jenkins
  • Build both arm64 and x86_64 macOS binaries
  • Build for oldest supported OS targets
  • Publish NPM package

- Reorganize in to matrix builds for less redundancy
- Use IBM approved actions
Updated node-pre-gyp attempting to resolve this issue, but it is still
unresolved upstream. For now, hack in a patch. Once upstream fixes
this, we can update to the fixed version and drop this hack.

For more details, see mapbox/node-pre-gyp#715
- Switch from "latest" to specific runner levels
- Add macos-13 for x86_64 (macos-14 is arm64 only it seems)
Add files section to package.json to only package the files we want.
Otherwise, npm publish will find and include the node-pre-gyp tar files
which we only want attached to the GitHub release.
@kadler kadler requested a review from abmusse August 21, 2024 22:21
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadler kadler merged commit 7e02158 into main Aug 21, 2024
4 checks passed
@kadler kadler deleted the cleanup-workflows branch August 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants