Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #641 - Extend document chunker transform to support fixed-size token window chunker with overlap #642

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

juancappi
Copy link
Contributor

Why are these changes needed?

Partially implements #641

This is a draft for pure python only. Ray is still pending

@juancappi juancappi marked this pull request as draft September 29, 2024 13:04
@juancappi juancappi force-pushed the feat/641-fixed-size-token-chunking branch from 43d36f1 to 242fad1 Compare September 29, 2024 13:05
@juancappi
Copy link
Contributor Author

@touma-I would you please take a look to confirm I'm in the right track?

@touma-I touma-I requested a review from dolfim-ibm October 3, 2024 15:44
to better reflect the new chunker is also leveraging a Llama Index chunker

Signed-off-by: Juan Cappi <[email protected]>
IBM#641
@juancappi juancappi marked this pull request as ready for review October 3, 2024 18:26
@juancappi
Copy link
Contributor Author

@dolfim-ibm this is ready for review

Copy link
Member

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@touma-I touma-I changed the title feat: #641 - first draft implementation, python only feat: #641 - Extend document chunker transform to support fixed-size token window chunker with overlap Oct 7, 2024
@touma-I touma-I merged commit d04454e into IBM:dev Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants