Fdedup package versioning and windows fixes #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Constantin Adam <[email protected]>
Signed-off-by: Constantin Adam <[email protected]>
touma-I
reviewed
Jan 30, 2025
| @@ -1,9 +1,9 @@ | |||
| pyyaml>=6.0.2 | |||
| boto3>=1.34.69 | |||
| kubernetes>=30.1.0 | |||
| polars==1.9.0 | |||
| polars>=1.13.0 | |||
There was a problem hiding this comment.
Please consider relaxing this to polars>=1.9.0. I have other modules that depend on polars and I want to make sure that all packages work together and meet the minimum requirements. Would your code break with 1.9.0 ?
There was a problem hiding this comment.
As I mentioned in issue #982, fuzzy dedup does not work with the following polars releases:
- 1.10.0
- 1.11.0
- 1.12.0
It works with any release before, and including1.9.0and after, or including 1.13.1. As long as you can exclude these three particular versions from polars, we are good.
Signed-off-by: Constantin Adam <[email protected]>
Signed-off-by: Constantin Adam <[email protected]>
Signed-off-by: Constantin Adam <[email protected]>
cmadam
changed the title
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
touma-I
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
mmh3andpolarspackagesRelated issue number (if any).
#982
#989