Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate -K supported tunables #605

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

nitismis
Copy link
Member

No description provided.

Signed-off-by: Nitish K Mishra <[email protected]>
@nitismis nitismis requested a review from schamola January 30, 2025 11:28
@nitismis nitismis self-assigned this Jan 30, 2025
Signed-off-by: Nitish K Mishra <[email protected]>
@neikei
Copy link
Contributor

neikei commented Jan 30, 2025

Thanks for the improvement triggered by my issue: #604

We will test this change and provide feedback. @Loeni01, it's your turn! 🚀

@neikei
Copy link
Contributor

neikei commented Jan 30, 2025

We did a first quick test without deeper analysis and it did not work for our example. I am not sure if this is because the function "validate_live_update" is just called with "tunable_params_with_value" but our example "clean_partial_conns" is in "tunable_params" without any value, because we want to "reset" this tunable.

Our input:

    "invocation": {
        "module_args": {
            "action": "reset",
            "bosboot_tunables": false,
            "change_type": "reboot",
            "component": "no",
            "restricted_tunables": false,
            "tunable_params": [
                "clean_partial_conns"
            ],
            "tunable_params_with_value": null
        }
    },

Function call:

        valid_live_update_tunables = validate_live_update(module, tunable_params_with_value)

@nitismis
Copy link
Member Author

Totally agree with you @neikei . The reason why I didn't merge the PR. Give me some time.

@nitismis
Copy link
Member Author

@neikei .. fixed .. waiting for verification !!

@Loeni01
Copy link
Contributor

Loeni01 commented Jan 31, 2025

We did a local test with the new tunables.py and everything works now.
Many thanks for the quick implementation @nitismis
Can you please create a new ansible collection release so that we can use the changes to the module?

@nitismis
Copy link
Member Author

@Loeni01 ,
Thanks for the verification, really appreciate it.
Regarding the release, YES !! we are planning to have a 2.0.3 release. I am stuck on multiple front today but rest assured that we will make the new release available by Monday. Hope it wont be too much of an issue.

@nitismis nitismis merged commit a397462 into IBM:dev-collection Jan 31, 2025
7 checks passed
@Loeni01
Copy link
Contributor

Loeni01 commented Feb 13, 2025

@nitismis Is there already an update on when the new Collection version 2.0.3 will be released? The Tunables module is broken in version 2.0.2 and cannot be used, so we are waiting for a new release.
Thanks in advance!

@Loeni01
Copy link
Contributor

Loeni01 commented Feb 13, 2025

I have just seen the new version 2.0.3 of the collection.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants