-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate -K supported tunables #605
Conversation
Signed-off-by: Nitish K Mishra <[email protected]>
Signed-off-by: Nitish K Mishra <[email protected]>
We did a first quick test without deeper analysis and it did not work for our example. I am not sure if this is because the function "validate_live_update" is just called with "tunable_params_with_value" but our example "clean_partial_conns" is in "tunable_params" without any value, because we want to "reset" this tunable. Our input: "invocation": {
"module_args": {
"action": "reset",
"bosboot_tunables": false,
"change_type": "reboot",
"component": "no",
"restricted_tunables": false,
"tunable_params": [
"clean_partial_conns"
],
"tunable_params_with_value": null
}
}, Function call: valid_live_update_tunables = validate_live_update(module, tunable_params_with_value) |
Totally agree with you @neikei . The reason why I didn't merge the PR. Give me some time. |
Signed-off-by: Nitish K Mishra <[email protected]>
@neikei .. fixed .. waiting for verification !! |
We did a local test with the new tunables.py and everything works now. |
@Loeni01 , |
@nitismis Is there already an update on when the new Collection version 2.0.3 will be released? The Tunables module is broken in version 2.0.2 and cannot be used, so we are waiting for a new release. |
I have just seen the new version 2.0.3 of the collection. |
No description provided.