-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ppc64le & multiarch support #136
base: master
Are you sure you want to change the base?
Conversation
This code is adding ppc64le and multiarch support for FfDL. - Adds new make target to the main Makefile: **docker-create-manifest** that creates the multiarch manifests for the services. - arch (architecture) parameter was added to values.yaml and storage-plugin/values.yaml **make docker-build** will generate all the services with a -${ARCHITECTURE} suffix. During build an ARCH argument is sent to the Dockerfiles in order to have architecture specific implementation inside it. Building docker images should look like this: make docker-build make docker-push make docker-create-manifest
Hi All, This code adds support for ppc64le in FfDL. It does adds a suffix to the built services with the architecture and also adds a target in the main Makefile to create/ammend the needed manifest lists to support the multiple architectures. There are two services that are needed by the code prom/pushgateway and localstack/localstack (optional) that does not have a ppc64le version in the public registries. I did generate custom build ppc64le version and pushed it to my own registry smonov. They will be pulled from there for now until published on a more official registry. |
values.yaml
Outdated
services: | ||
expose_node_port: true | ||
docker: | ||
registry: docker.io | ||
registry: ffdl.ibm.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes our official Docker image location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my mistake. This was not supposed to be there. Will fix it.
Found few issues. Fixing and testing them now:
|
Thanks @sdmonov. What is the target for travis if any? |
Could we not put the multi-arch storage plugin in a private repo and use it? The public travis ci is now multi-arch so you should do builds with it. I would like to see the changes in Travis.yaml file. We have to deal with learner images... is that addressed in a different PR? |
- added docker-tag-local target in Makefile - fixed few issues in docker-create-manifest target in Makefile - small fix in docker-push to not have duplicate code
|
This code is adding ppc64le and multiarch support for FfDL.
Adds new make target to the main Makefile: docker-create-manifest
that creates the multiarch manifests for the services.
arch (architecture) parameter was added to values.yaml and
storage-plugin/values.yaml
make docker-build will generate all the services with a -${ARCHITECTURE}
suffix. During build an ARCH argument is sent to the Dockerfiles in order
to have architecture specific implementation inside it.
Building docker images for ppc64le should look like this:
Fixes #115
Developer's Certificate of Origin 1.1