This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Conversation
animeshsingh
reviewed
Jul 6, 2018
Makefile
Outdated
|
|
||
| TRAVIS_IMAGE_VERSION ?= v0.1 | ||
| TEST_IMAGES = $(addprefix $(DOCKER_NAMESPACE)/, $(TEST_IMAGES_SUFFIX)) | ||
| TEST_IMAGES_SUFFIX = ffdl-lcm ffdl-trainer ffdl-metrics ffdl-databroker_s3 ffdl-ui ffdl-restapi ffdl-jobmonitor ffdl-controller log_collector ffdl-databroker_objectstorage tensorboard_extract |
Contributor
There was a problem hiding this comment.
This can probably be pulled from a config file? Makes it easier to extend.....
Contributor
Author
There was a problem hiding this comment.
Sure, I can put these into a config file.
animeshsingh
reviewed
Jul 6, 2018
| # deploy services | ||
| make $MAKE_ARGS deploy | ||
| # submit a test job | ||
| make $MAKE_ARGS test-submit-minikube-ci |
Contributor
There was a problem hiding this comment.
Given that test environment is still minikube - what all we are not able to test here?
Contributor
Author
There was a problem hiding this comment.
In theory we could, but putting everything into one single job will take longer time to finish. Also, it's easier to debug the 2 different environment if we run them in parallel.
animeshsingh
reviewed
Jul 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated PR for #49
bin/travis_scripts.Note: The new Travis job only checks pre-built images working on master branch but not pending PRs because any pending PRs changes will not be reflected in the pre-built images yet. But you can find a sample prebuilt images run of this PR at https://travis-ci.org/IBM/FfDL/builds/399363365
Developer's Certificate of Origin 1.1