Skip to content

skip service-id and trusted-profile-id validation when creating policies #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rajesh-Pirati
Copy link
Contributor

@Rajesh-Pirati Rajesh-Pirati commented Jul 8, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes https://github.ibm.com/IAM/AM-issues/issues/3414

Output from acceptance testing:

$ make testacc TEST=./ibm/service/iampolicy TESTARGS="-run TestAccIBMIAMServicePolicy"

=== RUN   TestAccIBMIAMServicePolicyDataSource_Basic
--- PASS: TestAccIBMIAMServicePolicyDataSource_Basic (51.93s)
=== RUN   TestAccIBMIAMServicePolicyDataSource_Multiple_Policies
--- PASS: TestAccIBMIAMServicePolicyDataSource_Multiple_Policies (54.47s)
=== RUN   TestAccIBMIAMServicePolicyDataSourceServiceSpecificAttributesConfig
--- PASS: TestAccIBMIAMServicePolicyDataSourceServiceSpecificAttributesConfig (24.73s)
=== RUN   TestAccIBMIAMServicePolicyDataSource_Time_Based_Conditions_Weekly
--- PASS: TestAccIBMIAMServicePolicyDataSource_Time_Based_Conditions_Weekly (46.87s)
=== RUN   TestAccIBMIAMServicePolicyDataSource_Time_Based_Conditions_Custom
--- PASS: TestAccIBMIAMServicePolicyDataSource_Time_Based_Conditions_Custom (24.74s)
=== RUN   TestAccIBMIAMServicePolicyDataSource_ServiceGroupID
--- PASS: TestAccIBMIAMServicePolicyDataSource_ServiceGroupID (23.02s)
=== RUN   TestAccIBMIAMServicePolicy_Basic
--- PASS: TestAccIBMIAMServicePolicy_Basic (35.90s)
=== RUN   TestAccIBMIAMServicePolicy_With_Service
--- PASS: TestAccIBMIAMServicePolicy_With_Service (33.73s)
=== RUN   TestAccIBMIAMServicePolicy_With_ServiceType
--- PASS: TestAccIBMIAMServicePolicy_With_ServiceType (18.48s)
=== RUN   TestAccIBMIAMServicePolicy_With_ResourceInstance
--- PASS: TestAccIBMIAMServicePolicy_With_ResourceInstance (46.92s)
=== RUN   TestAccIBMIAMServicePolicy_With_Resource_Group
--- PASS: TestAccIBMIAMServicePolicy_With_Resource_Group (21.95s)
=== RUN   TestAccIBMIAMServicePolicy_With_Resource_Type
--- PASS: TestAccIBMIAMServicePolicy_With_Resource_Type (23.37s)
=== RUN   TestAccIBMIAMServicePolicy_import
--- PASS: TestAccIBMIAMServicePolicy_import (23.20s)
=== RUN   TestAccIBMIAMServicePolicy_account_management
--- PASS: TestAccIBMIAMServicePolicy_account_management (20.43s)
=== RUN   TestAccIBMIAMServicePolicyWithCustomRole
--- PASS: TestAccIBMIAMServicePolicyWithCustomRole (20.40s)
=== RUN   TestAccIBMIAMServicePolicy_With_Resource_Attributes
--- PASS: TestAccIBMIAMServicePolicy_With_Resource_Attributes (35.25s)
=== RUN   TestAccIBMIAMServicePolicy_With_Resource_Tags
--- PASS: TestAccIBMIAMServicePolicy_With_Resource_Tags (36.40s)
=== RUN   TestAccIBMIAMServicePolicy_With_Transaction_Id
--- PASS: TestAccIBMIAMServicePolicy_With_Transaction_Id (37.86s)
=== RUN   TestAccIBMIAMServicePolicy_With_Time_Based_Conditions_Weekly_Custom
--- PASS: TestAccIBMIAMServicePolicy_With_Time_Based_Conditions_Weekly_Custom (37.10s)
=== RUN   TestAccIBMIAMServicePolicy_With_Time_Based_Conditions_Weekly_All_Day
--- PASS: TestAccIBMIAMServicePolicy_With_Time_Based_Conditions_Weekly_All_Day (19.56s)
=== RUN   TestAccIBMIAMServicePolicy_With_Time_Based_Conditions_Once
--- PASS: TestAccIBMIAMServicePolicy_With_Time_Based_Conditions_Once (19.50s)
=== RUN   TestAccIBMIAMServicePolicy_With_Update_To_Time_Based_Conditions
--- PASS: TestAccIBMIAMServicePolicy_With_Update_To_Time_Based_Conditions (27.01s)
=== RUN   TestAccIBMIAMServicePolicy_With_ServiceGroupID
--- PASS: TestAccIBMIAMServicePolicy_With_ServiceGroupID (35.97s)
=== RUN   TestAccIBMIAMServicePolicy_With_Attribute_Based_Condition
--- PASS: TestAccIBMIAMServicePolicy_With_Attribute_Based_Condition (37.22s)
=== RUN   TestAccIBMIAMServicePolicy_With_Resource_Attributes_Without_Wildcard
--- PASS: TestAccIBMIAMServicePolicy_With_Resource_Attributes_Without_Wildcard (19.10s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	776.952s

make testacc TEST=./ibm/service/iampolicy TESTARGS="-run TestAccIBMIAMTrustedProfilePolicy"

=== RUN   TestAccIBMIAMTrustedProfilePolicyDataSource_Basic
--- PASS: TestAccIBMIAMTrustedProfilePolicyDataSource_Basic (68.96s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyDataSource_Multiple_Policies
--- PASS: TestAccIBMIAMTrustedProfilePolicyDataSource_Multiple_Policies (69.03s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyDataSourceServiceSpecificAttributesConfig
--- PASS: TestAccIBMIAMTrustedProfilePolicyDataSourceServiceSpecificAttributesConfig (36.19s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyDataSource_Time_Based_Conditions_Weekly
--- PASS: TestAccIBMIAMTrustedProfilePolicyDataSource_Time_Based_Conditions_Weekly (35.50s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyDataSource_Time_Based_Conditions_Custom
--- PASS: TestAccIBMIAMTrustedProfilePolicyDataSource_Time_Based_Conditions_Custom (36.16s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyDataSource_ServiceGroupID
--- PASS: TestAccIBMIAMTrustedProfilePolicyDataSource_ServiceGroupID (34.48s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyBasic
--- PASS: TestAccIBMIAMTrustedProfilePolicyBasic (53.29s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Service
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Service (55.06s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_ServiceType
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_ServiceType (28.42s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_ResourceInstance
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_ResourceInstance (57.02s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Resource_Group
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Resource_Group (36.69s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Resource_Type
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Resource_Type (38.64s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_import
--- PASS: TestAccIBMIAMTrustedProfilePolicy_import (32.52s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_account_management
--- PASS: TestAccIBMIAMTrustedProfilePolicy_account_management (28.55s)
=== RUN   TestAccIBMIAMTrustedProfilePolicyWithCustomRole
--- PASS: TestAccIBMIAMTrustedProfilePolicyWithCustomRole (25.99s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Resource_Attributes
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Resource_Attributes (52.72s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Resource_Attributes_Without_Wildcard
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Resource_Attributes_Without_Wildcard (28.60s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Resource_Tags
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Resource_Tags (57.38s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Transaction_Id
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Transaction_Id (29.26s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Time_Based_Conditions_Weekly_Custom
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Time_Based_Conditions_Weekly_Custom (52.50s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Time_Based_Conditions_Weekly_All_Day
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Time_Based_Conditions_Weekly_All_Day (27.83s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Time_Based_Conditions_Once
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Time_Based_Conditions_Once (28.31s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Update_To_Time_Based_Conditions
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Update_To_Time_Based_Conditions (42.99s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_ServiceGroupID
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_ServiceGroupID (52.68s)
=== RUN   TestAccIBMIAMTrustedProfilePolicy_With_Attribute_Based_Condition
--- PASS: TestAccIBMIAMTrustedProfilePolicy_With_Attribute_Based_Condition (55.06s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy	1066.438s

@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review July 8, 2025 14:04
@Rajesh-Pirati Rajesh-Pirati force-pushed the 3414-skip-subject-id-validation branch from aecd484 to 5698255 Compare July 9, 2025 06:10
@Rajesh-Pirati Rajesh-Pirati marked this pull request as draft July 14, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant