feat: update vmware service #6329
Open
+680
−339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sneha Kamat <[email protected]>
SnehaKamat1
requested review from
hkantare,
uibm,
kavya498 and
omaraibrahim
as code owners
Signed-off-by: Sneha Kamat <[email protected]>
uibm
reviewed
Jul 18, 2025
| @@ -6,20 +6,21 @@ provider "ibm" { | |||
| resource "ibm_vmaas_vdc" "vmaas_vdc_instance" { | |||
| accept_language = var.vmaas_vdc_accept_language | |||
| cpu = var.vmaas_vdc_cpu | |||
| name = var.vmaas_vdc_name | |||
| ram = var.vmaas_vdc_ram | |||
There was a problem hiding this comment.
can you run terraform fmt on these files ?
| @@ -31,11 +31,6 @@ func DataSourceIbmVmaasVdc() *schema.Resource { | |||
| Required: true, | |||
| Description: "A unique ID for a specified virtual data center.", | |||
| }, | |||
| "accept_language": &schema.Schema{ | |||
There was a problem hiding this comment.
No this is not a breaking change
uibm
reviewed
Jul 18, 2025
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { acc.TestAccPreCheckVMwareService(t) }, | ||
| Providers: acc.TestAccProviders, | ||
| CheckDestroy: testAccCheckIbmVmaasVdcDestroy, | ||
| Steps: []resource.TestStep{ | ||
| resource.TestStep{ | ||
| Config: testAccCheckIbmVmaasVdcConfigBasic(ds_id, ds_pvdc_id, name), | ||
| Config: testAccCheckIbmVmaasVdcConfigBasic(name, id, pvdc_id), |
There was a problem hiding this comment.
name and name update are same ?
uibm
reviewed
Jul 18, 2025
| @@ -169,6 +188,7 @@ func ResourceIbmVmaasVdc() *schema.Resource { | |||
| }, | |||
| "private_only": &schema.Schema{ | |||
| Type: schema.TypeBool, | |||
| Optional: true, | |||
uibm
reviewed
Jul 18, 2025
| @@ -206,6 +226,7 @@ func ResourceIbmVmaasVdc() *schema.Resource { | |||
| }, | |||
| "transit_gateway_connection_name": &schema.Schema{ | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
There was a problem hiding this comment.
this is not required ? Optional on a computed list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
