RR trivial updates may 2024 #497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #477 |
|
Very interesting, thanks @robredpath ! All the punctuation changes would be welcome, and don't seem to change any meaning of the schema text The two changes that (rightly) change the word activity for organisation are also good spots. They feel slightly different to the punctuation - a correction, rather than a grammatical improvement. But that's splitting hairs [full stop]. Over to @Bjwebb for thoughts.... |
stevieflow
reviewed
May 28, 2024
| @@ -104,7 +104,7 @@ | |||
| <xsd:annotation> | |||
| <xsd:documentation xml:lang="en"> | |||
| Default ISO 4217 currency code for all financial values in | |||
| this activity report. If this is not declared then the | |||
| this organisation report. If this is not declared then the | |||
There was a problem hiding this comment.
Agree - the org file contains financial data, so this should say "organisation".
stevieflow
reviewed
May 28, 2024
| @@ -49,7 +49,7 @@ | |||
| <xsd:documentation xml:lang="en"> | |||
| A date/time stamp for when this file was generated. This | |||
| is not necessarily the last-updated date for the | |||
| individual activity records in it. Use of this attribute | |||
| individual organisation records in it. Use of this attribute | |||
There was a problem hiding this comment.
Also agree. There can be multiple organisations in any organisation file, and this timestamp relates to them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some very trivial typos and consistency issues I spotted while looking at the schemas.