Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support windows visibility events #204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

i10416
Copy link
Contributor

@i10416 i10416 commented Feb 8, 2022

I temporarily named event as EventWindowAppear/Disappear, but I think there would be better candidates.

Which do you think is better for visibility event name?

  • EventWindowShow/Hidden
  • EventWindowAppear/Disappear
  • EventWindowVisibilityOn/Off
  • EventWindowVisible/Invisible
  • other

JWM notifies when window's visibility changes. In Windows, visibility is based mainly on WS_VISIBLE property and
updated by ShowWindow function and ShowOwnedPopups function.

see

JWM notifies when window's visibility changes. In Windows, visibility is based mainly on WS_VISIBLE property and
updated by ShowWindow function and ShowOwnedPopups function.

see
- https://github.com/MicrosoftDocs/win32/blob/docs/desktop-src/winmsg/window-features.md#window-visibility
- https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-showwindow
@tonsky
Copy link
Collaborator

tonsky commented Feb 8, 2022

How does it relate to minimize/maximize/restore (we already have those)? Minimize == hidden? Restore == visible? Or is there a subtle difference?

@i10416
Copy link
Contributor Author

i10416 commented Apr 13, 2022

How does it relate to minimize/maximize/restore (we already have those)? Minimize == hidden? Restore == visible? Or is there a subtle difference?

It is not related to actual window visibility. It reacts to ShowWindow function and ShowOwnedPopups function, but does not react to manually resizing(hiding) window🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants