Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Custom Flags for PASCAL VOC and c shortcut #712

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jjjkkkjjj-mizuno
Copy link

@jjjkkkjjj-mizuno jjjkkkjjj-mizuno commented Feb 26, 2021

Hi, thank you for your excellent annotation tool!
I've just implemented custom flags for PASCAL VOC Dataset, which we can annotate any flag we want to set!

Also, I added c shortcut key of copy previous shape instead of ctrl+v.

@jjjkkkjjj-mizuno
Copy link
Author

GUI is like this;
image

So, we can add a flag by pushing or Enter key, and delete a flag by pushing X

Copy link
Contributor

@tzutalin tzutalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it looks ok. But could you remove unnecessary comment and files before merging? Thanks

build.bat Outdated
@@ -0,0 +1,6 @@
rd /s /q dist build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to submit this build.bat file?

activate.bat Outdated
@@ -0,0 +1,2 @@
pushd \\Mac\Home\Documents\programs\software\labelImg_copyfunc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to have activate.bat ?

labelImg.py Outdated
@@ -135,6 +135,14 @@ def __init__(self, defaultFilename=None, defaultPrefdefClassFile=None, defaultSa
self.editButton = QToolButton()
self.editButton.setToolButtonStyle(Qt.ToolButtonTextBesideIcon)

# *
# * dhzs 2017-12-2 add copy button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is not needed. could we remove it?

@jjjkkkjjj-mizuno
Copy link
Author

@tzutalin
Thank you for reviewing my codes!

But could you remove unnecessary comment and files before merging?

Sorry, I mistook committing unnecessary files in 7cbe685.
I'll remove the comment and files in 7b67c2c and dd6f703.
So could you review them again? Thank you!

Also, I added "Discard the unnecessary flags" function in 795e993, by which you can discard the flags that doesn't exist in rightdock.

If you don't want to do "merge squash", I can modify the commit( 7cbe685) of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants