feat: LEAP-2036: Summary page for View All #7439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a special Summary page inside View All view to display all labelings across all annotations in current task. Here are the LabelingSummary and DataSummary components to display info about control tags and object tags respectively.
Proper user info for Userpic and `user` in store. Proper types for them.
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
nass600
reviewed
May 6, 2025
| @@ -47,7 +47,8 @@ import { ToastProvider, ToastViewport } from "@humansignal/ui/lib/toast/toast"; | |||
| import { Annotation } from "./Annotation"; | |||
| import { BottomBar } from "../BottomBar/BottomBar"; | |||
| import Debug from "../Debug"; | |||
| import Grid from "./Grid"; | |||
| // import Grid from "./Grid"; | |||
| import Summary from "../Summary/Summary"; | |||
There was a problem hiding this comment.
I would use a more precise name for this component given it is pretty open, maybe AnnotationSummary or ReviewSummary or anything else that gives a bit more information
| <table className="table-auto w-full"> | ||
| <thead> | ||
| <tr> | ||
| {Object.entries(data_types).map(([field, type]) => ( |
There was a problem hiding this comment.
I would add a check here so we can safely assume we will have data_types
|
|
||
| export const LabelingSummary = ({ annotations, controls }: Props) => { | ||
| return ( | ||
| <table className="w-full"> |
There was a problem hiding this comment.
Unless specifically needed I would use Grid over tables so we can easily ensure a responsive design
It chooses between tabbed view with FF ON and usual Grid with FF OFF. Tabbed view has new Summary tab and old Grid tab. Selected tab is preserved between sessions.
- no tooltip on avatar, we already show names - annotation tabs are always displayed with new Summary
- Add TextArea tag - Add support for per-regions - for now per-region flag is calculated by simple rule: >1 results -> per-region - Move renderers to a separate file - Allow to return null to fallback to default text
More semantic styles. Local Card component. Numbers on the top.
All labels will be displayed the same, so just reuse the same renderer.
Gondragos
reviewed
May 8, 2025
Agreement is calculated on backend over submitted annotations. So displayed results should also be only submitted once. We have `versions` with `draft` and `result`, so we should use the latter.
hlomzik
changed the title
Get (almost) all info about tags from LSF; don't use DM. The only lefover is agreement, should be fixed soon. Fix all the related code to work with real tags. Add new types to describe store and tags. Fix linting here and there.
This automatically accepts agreement passed via `task` from outer sources.
|
/git merge
|
…tudio into fb-leap-2036/summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a special Summary page inside View All view to display all labelings across all annotations in current task.
Here are the
LabelingSummaryandDataSummarycomponents to display info about control tags and object tags respectively.