Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1783, DIA-1794: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE #7009

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

nick-skriabin
Copy link
Member

@nick-skriabin nick-skriabin commented Feb 3, 2025

Brings Tailwind and Shadcn as a new standard.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@nick-skriabin nick-skriabin requested a review from a team as a code owner February 3, 2025 12:54
@github-actions github-actions bot added the feat label Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 97c61f6
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67c0964fd757aa0008fcacf9

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 97c61f6
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67c0964f7ab2920008ff3cfa

@nick-skriabin nick-skriabin changed the title feat: DIA-1783: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE feat: DIA-1783, DIA-1794: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (8ce1109) to head (2a435a7).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/views.py 33.33% 4 Missing ⚠️
label_studio/users/views.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7009      +/-   ##
===========================================
- Coverage    77.09%   77.06%   -0.03%     
===========================================
  Files          183      183              
  Lines        14406    14413       +7     
===========================================
+ Hits         11106    11108       +2     
- Misses        3300     3305       +5     
Flag Coverage Δ
pytests 77.06% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nick-skriabin
Copy link
Member Author

nick-skriabin commented Feb 13, 2025

/git merge

Workflow run
Error: Workflow failed

@nick-skriabin
Copy link
Member Author

nick-skriabin commented Feb 21, 2025

/docker build

Workflow run
Docker image was pushed with the tag 20250221.173814-fb-dia-1783-tailwind-next-2a435a726

@nick-skriabin
Copy link
Member Author

nick-skriabin commented Feb 26, 2025

/docker build

Workflow run
Docker image was pushed with the tag 20250226.164529-fb-dia-1783-tailwind-next-3bb07c7d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant