Added enzymatic tissue dissociation fields #1599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ac-tissue-dissociation-Issue1592
ESapenaVentura
requested changes
Dec 20, 2024
| }, | ||
| "digestion_temperature": { | ||
| "description": "Temperature of digestion in Celsius or in general terms (i.e. cold, warm, room temperature).", | ||
| "pattern": "\\d+(\\.\\d+)?|frozen|cold|room temperature|warm", |
There was a problem hiding this comment.
Pattern must be anchored (And it should be grouped in order to properly capture alternative groups):
Suggested change
| "pattern": "\\d+(\\.\\d+)?|frozen|cold|room temperature|warm", | |
| "pattern": "^(\\d+(\\.\\d+)?|frozen|cold|room temperature|warm)$", |
There was a problem hiding this comment.
Otherwise, things like "11frozen", "frozencold" will be accepted https://regex101.com/r/iRzCpr/1
| @@ -1 +1,6 @@ | |||
| Schema,Change type,Change message,Version,Date | |||
| type/protocol/biomaterial_collection/dissociation_protocol,minor,Changed of user_friendly name of reagent field,, | |||
There was a problem hiding this comment.
Suggested change
| type/protocol/biomaterial_collection/dissociation_protocol,minor,Changed of user_friendly name of reagent field,, | |
| type/protocol/biomaterial_collection/dissociation_protocol,minor,Changed user_friendly name of reagent field,, |
very very minor correction :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1592
Release notes
For
dissociation_protocol.jsonschema:reagentsfriendly name to distinguish withdigestion_solutiondigestion_timedigesion_time_unitsdigestion_temperaturedigestion_solutionReviews requested