Add babel loader #15
Open
Add babel loader #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Babel loader is a peer requirement for @cypress/webpack-preprocessor. - Remove peer dependencies
darkmavis1980
previously approved these changes
Aug 30, 2023
|
Sorry @denisolvr I had a PR open for a while and I merged it, can you pull the latest changes from |
This reverts commit 110ed9e.
darkmavis1980
previously approved these changes
Aug 31, 2023
added 2 commits
August 31, 2023 13:38
cfrisoli
reviewed
Aug 31, 2023
| @@ -27,6 +27,7 @@ | |||
| "@babel/preset-env": "^7.22.9", | |||
| "@cypress/webpack-preprocessor": "^5.17.1", | |||
There was a problem hiding this comment.
Just noticing now that we have this as a package dependency, Should we should have cypress dependency as a dependency for this package? not all projects use cypress so hence why I ask.
cc @david-mooney
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes 📋