Overhaul current path reconstruction in eager execution #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macro function executed with nested interpretation was not preserved. With this change, by wrapping the output in a child scope, the current_path is preserved
evaluated macro output
state to be meta context variables. Update var names to be consistent and update usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the newer way of reconstructing the current_path, introduced in #1177 and applies it to more places where we reconstruct the path by wrapping the initial and new path.
It also adds a new class for tracking the meta context variables
MetaContextVariables, specifically causing the temporary variables forcurrent_pathand import resource alias to be considered as meta context variables.This is a more comprehensive way of solving #1199 and it also doesn't change non-eager execution code. It does that by wrapping the partially evaluated macro function output in a child scope (with
{% for __ignored__ in [0] %})Several minor QOL improvements are made here too.