[2.1 | PSP] Generate PARAM.SFO / Fix HOME button

[antim0118]

No description provided.

[technicaljicama]

I'd put the callbacks into Godot_PSP.cpp to make it look cleaner

[halotroop2288]

This looks good to me, and I disagree about putting anything in godot_psp.cpp because usually the main file is only used for bootstrapping the engine. The OS class does the rest of the initialization.

In the future, you should avoid making unrelated changes part of the same pull request. Small and simple changes can be approved and merged much quicker by themselves.

[halotroop2288]

I guess you're just ignoring my advice about unrelated changes then? I can't easily review changes like that audio crackling. I won't be merging this now, myself.

[antim0118]

I guess you're just ignoring my advice about unrelated changes then? I can't easily review changes like that audio crackling. I won't be merging this now, myself.

Got it. I didn't expect commits to be shown there.
In any case, there is a compilation bug there.