-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Add platform-switch submodule #16
base: 3.5
Are you sure you want to change the base?
Conversation
Briefly looked at this but am not confident I can review it right now, partly because I'm very tired and partly because the diff github is showing me from this commit is giving me a headache, it understandably has a whole bunch of additions that were already added to the repo ages ago, but I just want to see what's actually been changed here since the original commits from PR #3. Here's where only using git casually and svn in my day job has left me baffled - I have no idea how I'm supposed to check what has actually been changed in this PR, or if that's even possible, as there's no way the diff I'm being shown is accurate. Ideally I'd just want a diff of what's actually changed, and while I could probably stitch something together by grabbing diffs from older PRs, that sounds like a huge headache - hoping you know of a better way? (Either way, looks like I'll be giving myself through a quick refresher on some git functionality I've never had a reason to use and not touched since university) |
That's because you're expecting it to be the difference between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Far as I can tell the submodule to https://github.com/Homebrodot/platform-switch all looks good, and the new 3.5 branch has the main/3.5 switch-specific core/non-platform changes it needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion on the main/3.5 branch...
f950ebd#r138181091
...can potentially avoid having any modifications to this file at all to add in Switch in support if we override OS::get_resource_path for the switch
That'll be a change that'll need doing on the platform-switch submodule repo rather than here, but wanted a note to remain on this branch as reminder that we should be able to remove it in a future update.
Supersedes #9, as that approach did not work correctly.
Modifies commits from #3 to reduce the amount of changes outside the
platforms
directory.