Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scheduled workflow to use pages v4 #629

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Update scheduled workflow to use pages v4 #629

merged 2 commits into from
Jun 13, 2024

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jun 12, 2024

Closes Homebrew/brew#17379

This PR modifies the scheduled regeneration workflow to mimic the one used for formulae.brew.sh.

I've removed the generated site files from docs and updated the .gitignore file appropriately. If we want, we could rewrite the history of the repo to remove the generated files and make cloning take much less time (I can't remember whether we did that for formulae.brew.sh or not).

The scheduled task now has three jobs:

  1. generate generates the site from Homebrew/brew, and also builds the site (i.e. runs bundle exec rake yard build). I figured because there is only one generation task, there's no real benefit to splitting this up into a separate generate and build job, but we can do that if we want to more closely mimic formulae.brew.sh
  2. deploy deploys the site to GitHub pages
  3. deploy-issue opens/closes deploy failure issues just like in formulae.brew.sh

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work here @Rylan12!

@MikeMcQuaid MikeMcQuaid merged commit 30d6bff into master Jun 13, 2024
4 checks passed
@MikeMcQuaid MikeMcQuaid deleted the pages-v4 branch June 13, 2024 07:59
MikeMcQuaid added a commit that referenced this pull request Jun 13, 2024
@MikeMcQuaid
Copy link
Member

If we want, we could rewrite the history of the repo to remove the generated files and make cloning take much less time (I can't remember whether we did that for formulae.brew.sh or not).

We did for formulae.brew.sh and I just did for rubydoc.brew.sh, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make rubydoc.brew.sh workflow more like formulae.brew.sh
2 participants