test_cleanup: fix moving of same-named files #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic for moving files can silently fail when some files to
move have a same name. This can be revealed as follows:
$ mv -fv /opt/homebrew/Library/Taps/hashicorp/homebrew-tap /opt/homebrew/Library/Taps/azure/homebrew-bicep /opt/homebrew/Library/Taps/aws/homebrew-tap /private/tmp/d20241005-13189-6pyqe7
/opt/homebrew/Library/Taps/hashicorp/homebrew-tap -> /private/tmp/d20241005-13189-6pyqe7/homebrew-tap
/opt/homebrew/Library/Taps/azure/homebrew-bicep -> /private/tmp/d20241005-13189-6pyqe7/homebrew-bicep
mv: rename /opt/homebrew/Library/Taps/aws/homebrew-tap to /private/tmp/d20241005-13189-6pyqe7/homebrew-tap: Directory not empty
Fix that by creating a temporary directory for each file to move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 at #1250; fixes #1250 (comment).
The existing logic for moving files can silently fail when some files to move have a same name. This can be revealed as follows:
Fix that by creating a temporary directory for each file to move.