Use --concurrency with brew fetch
#1244
Conversation
This should hopefully make CI just a little bit faster. It'll help us kick the tires on `--concurrency`.
carlocab
force-pushed
the
concurrent-fetch
branch
from
4c5c2ea
to
a4cea91
Compare
| @@ -31,7 +31,9 @@ def fetch_bottles!(formula_name, args:) | |||
|
|
|||
| tags.each do |tag| | |||
| cleanup_during!(args:) | |||
| test "brew", "fetch", "--retry", "--formulae", "--bottle-tag=#{tag}", formula_name | |||
| test "brew", "fetch", "--retry", "--formulae", "--bottle-tag=#{tag}", | |||
| "--concurrency", Homebrew::EnvConfig.make_jobs, | |||
There was a problem hiding this comment.
What is Homebrew::EnvConfig.make_jobs in CI usually?
There was a problem hiding this comment.
Same as default -- number of cores. So somewhere between 2-6.
There was a problem hiding this comment.
Hold off on this. Would like to see some more of Homebrew/brew#18278 (comment) done first, at least:
we should limit the hosts we'll download in parallel from to an allowlist so we don't e.g. try to download the 10 files at once from a poor personal web server when building from source
For now: starting with just GitHub and GitHub Packages makes sense to me.
To be explicit on what this means: it's ok to have 1 thread download from e.g. randomwebserver.com but not >1 at once unless it's e.g. GitHub.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This should hopefully make CI just a little bit faster. It'll help us
kick the tires on
--concurrency.