Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_formulae: relax cache invalidation criteria #1243

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

carlocab
Copy link
Member

We don't need to throw out our cached bottle if the only dependencies
that have changed are build- or test-only.

We don't need to throw out our cached bottle if the only dependencies
that have changed are build- or test-only.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions:

  • does this not run the risk of the build/test cache having been poisoned?
  • does this handle as expected the case where it's e.g. a build/test dependency of the current formula but a runtime dependency of a recursive dependency?

Good to merge once both of these are confidently 👍🏻

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Oct 22, 2024
@carlocab
Copy link
Member Author

  • does this not run the risk of the build/test cache having been poisoned?

No more (or less) than the existing risk, since the Git hash check only verifies that dependencies haven't changed in Git since the cached bottles were last built.

  • does this handle as expected the case where it's e.g. a build/test dependency of the current formula but a runtime dependency of a recursive dependency?

It should, yes.

@carlocab carlocab merged commit 384c6ca into master Oct 23, 2024
4 checks passed
@carlocab carlocab deleted the relax-cache-invalidation branch October 23, 2024 11:10
@MikeMcQuaid
Copy link
Member

Great, thanks for responding @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants