Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run brew typecheck as part of (some) tap_syntax tests #1173

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Run brew typecheck as part of (some) tap_syntax tests #1173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ebdbd
Run `brew typecheck` as part of (some) `tap_syntax` tests
issyl0 Aug 19, 2024
67d79c2
Don't hardcode taps that support Sorbet
issyl0 Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/tests/tap_syntax.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,18 @@
module Homebrew
module Tests
class TapSyntax < Test
# Eventually these should be all `tap.official?` taps except core & cask?
issyl0 marked this conversation as resolved.
Show resolved Hide resolved
SORBET_TAPS = %w[
homebrew/command-not-found
homebrew/services
].freeze

issyl0 marked this conversation as resolved.
Show resolved Hide resolved
def run!(args:)
test_header(:TapSyntax)
return unless tap.installed?

test "brew", "typecheck", tap.name if SORBET_TAPS.include?(tap.name)
issyl0 marked this conversation as resolved.
Show resolved Hide resolved

test "brew", "style", tap.name unless args.stable?

return if tap.formula_files.blank? && tap.cask_files.blank?
Expand Down
Loading