Add stable option to restrict tap syntax checks #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Cho <[email protected]>
MikeMcQuaid
approved these changes
Apr 15, 2024
MikeMcQuaid
reviewed
Apr 15, 2024
Comment on lines
+74
to
+76
| switch "--stable", | ||
| depends_on: "--only-tap-syntax", | ||
| description: "Only run the tap syntax checks needed on stable brew." |
There was a problem hiding this comment.
Whoops, only thought more after merge: I think this is maybe a bit unclear for third-party taps as to what it's doing? What about making this --skip-audit instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Homebrew/homebrew-core#166913
Wasn't sure if we wanted a mutually exclusive arg (and optionally a separate Test) or just a dependent arg. Went with the simplest change which is
--stableoption.