cleanup_before: untap unneeded taps on GitHub-hosted runners #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help us get rid of the strange warnings seen in [^1]. `aws/tap/aws-sam-cli` calls `opoo` unconditionally once evaluated [^2]. The tap `aws/tap` is installed on GitHub-hosted runners, and we evaluate all formulae when determining the dependents of testing formulae. A more ideal and comprehensive solution would be to untap all unneeded taps by (recursively) determining which taps are actually needed by the formulae in the testing tap, but that requires evaluating all formulae in the testing tap and can be a bit more work. And in the end, for third-party taps, doing that will still not eliminate the warnings if a dependency has an unconditional `opoo` call like that. So for now, I'm restricting the cleanup to `homebrew/core`. [^1]: https://github.com/Homebrew/homebrew-core/actions/runs/11148695947/job/30986582554?pr=192640 [^2]: https://github.com/aws/homebrew-tap/blob/f2dcc08fa89256b3893a6cfc82e3ac71b05ce28e/Formula/_aws-sam-cli.rb#L58
|
homebrew-test-bot/lib/test_cleanup.rb Lines 107 to 115 in d332acb |
Bo98
reviewed
Oct 2, 2024
Comment on lines
+53
to
+57
| if on_github_hosted_runner && tap.to_s == CoreTap.instance.name | ||
| (installed_taps - REQUIRED_TAPS).each do |tap| | ||
| test "brew", "untap", tap | ||
| end | ||
| end |
There was a problem hiding this comment.
Won't this untap homebrew/core? It is not a required tap.
There was a problem hiding this comment.
Whoops -- I misread REQUIRED_TAPS as there was a CoreTap.instance.name below but that's ALLOWED_TAPS.
|
Thanks @ZhongRuoyu, this needed reverted but I still think this approach is worth pursuing!
Yes, I think it'd be good to fixup that logic to handle this as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help us get rid of the strange warnings seen in 1.
aws/tap/aws-sam-clicallsopoounconditionally once evaluated 2. The tapaws/tapis installed on GitHub-hosted runners, and we evaluate all formulae when determining the dependents of testing formulae.A more ideal and comprehensive solution would be to untap all unneeded taps by (recursively) determining which taps are actually needed by the formulae in the testing tap, but that requires evaluating all formulae in the testing tap and can be a bit more work. And in the end, for third-party taps, doing that will still not eliminate the warnings if a dependency has an unconditional
opoocall like that. So for now, I'm restricting the cleanup tohomebrew/core.Footnotes
https://github.com/Homebrew/homebrew-core/actions/runs/11148695947/job/30986582554?pr=192640 ↩
https://github.com/aws/homebrew-tap/blob/f2dcc08fa89256b3893a6cfc82e3ac71b05ce28e/Formula/_aws-sam-cli.rb#L58 ↩