Basic Sorbet typed: true
#711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
issyl0
commented
Aug 17, 2024
issyl0
commented
- I thought I'd use this as a test bed for dev-cmd/typecheck: Support typechecking in taps brew#18027. Now we have a minimal successful Sorbet typed tap.
issyl0
force-pushed
the
wip-srb
branch
2 times, most recently
from
f279a1d
to
b3ea301
Compare
issyl0
commented
Aug 17, 2024
Bo98
approved these changes
Aug 18, 2024
|
I'll mark this as ready and re-run CI once Homebrew/brew#18027 merges later today. |
``` ./cask/artifact/symlinked.rb:38: Too many arguments provided for method Formatter.error. Expected: 1, got: 2 https://srb.help/7004 38 | Formatter.error(string, label: "Broken Link") ^^^^^^^^^^^^^^^^^^^^ /opt/homebrew/Library/Taps/homebrew/homebrew-services/spec/spec_helper.rb:44: error defined here 44 | def error(string) ^^^^^^^^^^^^^^^^^ Autocorrect: Use -a to autocorrect ./cask/artifact/symlinked.rb:38: Delete 38 | Formatter.error(string, label: "Broken Link") ``` - Sorbet's confused about the order of things, but we can read this as the services definition is wrong, it should say it's pulled from but instead it's the other way around because Sorbet's ordering.
|
Thanks, @Bo98 - rebased this. |
MikeMcQuaid
approved these changes
Aug 19, 2024
MikeMcQuaid
reviewed
Aug 19, 2024
Bo98
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.