Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck issues #217

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

samford
Copy link
Member

@samford samford commented Jun 12, 2024

shellcheck is reporting SC2086 ("Double quote to prevent globbing and word splitting") issues in the release.yml workflow. This adds quotes around the related areas to resolve the issues.

There's still one remaining actionlint issue in build.yml but it may be a false positive (as described in Homebrew/brew#17482 (comment)):

homebrew-portable-ruby/.github/workflows/build.yml:27:16: object, array, and null values should not be evaluated in template with ${{ }} but evaluating the value of type {image: string; options: string} [expression]
   |
27 |     container: ${{matrix.container}}
   |                ^~~~~~~~~~~~~~~~~~~~~

Related to Homebrew/brew#17482

`shellcheck` is reporting SC2086 ("Double quote to prevent
globbing and word splitting") issues in the `release.yml` workflow.
This adds quotes around the related areas to resolve the issues.
@Bo98 Bo98 merged commit f20bc9f into Homebrew:master Jun 13, 2024
5 checks passed
@samford samford deleted the brew-style-shellcheck-fixes branch June 13, 2024 00:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants