Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cache step and fix shellcheck error #63

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

colindean
Copy link
Member

@colindean colindean commented Dec 14, 2024

I think this will unblock #62.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@colindean colindean changed the title Double quote to prevent globbing and word splitting Add missing cache step and fix shellcheck error Dec 14, 2024
@colindean colindean marked this pull request as ready for review December 14, 2024 06:17
@tani tani merged commit beb020b into Homebrew:master Dec 14, 2024
1 check passed
@colindean colindean deleted the patch-1 branch December 14, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants