cmd/generate-analytics-api: concurrently run commands #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
~6m -> ~1.5m |
SMillerDev
approved these changes
Jan 19, 2024
|
Very nice work @Bo98. Will need to keep an eye on InfluxDB rejecting requests again but the speedup is well worth a try. |
|
Yeah I tried a lot to make the rejecting thing happen but have never managed to do so, so maybe was a thing of the past. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanting to try this again as analytics API generation is consistently several times slower than the rest of the API generation, but concurrency here could make it as fast as the rest.
Was planning to try the new Ractors thing Ruby has but it needs a number of changes in
brewto make it compatible with them.