Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
performance
server config blockIts only member was 'query_parallelism`, which was unused. Existing config files with this key will still parse.
go-mysql-server
Optimizes SQL() implementations that convert interface values into type-specific byte arrays. Combination of skipping
runtime.convT
checks, that unnecessarily allocated variables to the heap, redundant byte array copying, and other conversion inefficiencies.dolt perf here: [no-release-notes] skip more wire allocs dolthub/dolt#8651
caching_sha2_password
authThis change enables users configured with the
caching_sha2_password
auth plugin to authenticate to a running SQL server. The default authentication plugin is stillmysql_native_password
, but users can opt-in tocaching_sha2_password
by creating a user and explicitly specifying the auth plugin.Note that the
caching_sha2_password
auth plugin requires running the SQL server with a certificate so that TLS connections can be established.Depends on: Minor bug fixes for
caching_sha2_password
auth logic dolthub/vitess#390Related to: Support
caching_sha2_password
authentication method dolthub/dolt#8496caching_sha2_password
auth pluginThis change enables customers to create users configured to authenticate with the
caching_sha2_password
auth plugin. The generated authentication string uses the same logic as MySQL'scaching_sha2_password
auth plugin. Users created withcaching_sha2_password
can not yet authenticate with a GMS server – the next change in this series will enable that.Example usage:
caching_sha2_password
auth strings dolthub/vitess#387Related to: Support
caching_sha2_password
authentication method dolthub/dolt#8496vitess
caching_sha2_password
auth logicFor accounts without passwords, we need to account for the client sending the null byte when the server re-requests the client auth data, and then skip the
AuthMoreDataPacket
, andCachingSha2FastAuth
packets. Otherwise themysql
client errors with "Malformed packet".handleConnectionError
is used to report stats about failed connection attempts, but wasn't being called in the correct spot. The previous spot was over counting failed connection attempts, since it was called as part of the auth renegotiation flow. It has been moved to be called whenever we return an error or exit the function without a successful connection.explain plan
For debugging purposes, we replaced MySQL's
EXPLAIN
output with our very own.Unfortunately, it is not causing problems, so we must move our syntax into its own thing.
caching_sha2_password
auth stringsClosed Issues