Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sile 0.15.8 #197800

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sile 0.15.8 #197800

wants to merge 4 commits into from

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Nov 15, 2024

Replaces #197650 which doesn't actually take into consideration any of the details of this update like removing the now obsolete ICU workaround or using the new upstream configure flag that was specifically to accommodate Homebrew's resource handling.

To be merged after #196600 which takes care of some other known issues unrelated to the version bump.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. lua Lua use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Nov 15, 2024
@daeho-ro daeho-ro mentioned this pull request Nov 27, 2024
1 task
@alerque alerque marked this pull request as ready for review November 29, 2024 11:07
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 3, 2024
@alerque
Copy link
Contributor Author

alerque commented Dec 3, 2024

Something seems to be wrong with linking the new dynamically loaded rusile module on Darwin, I'm looking into it upstream. Marking this as draft until that is resolved.

@alerque alerque changed the title sile 0.15.6 sile 0.15.8 Dec 12, 2024
@alerque alerque marked this pull request as ready for review December 12, 2024 09:16
@alerque
Copy link
Contributor Author

alerque commented Dec 12, 2024

Somehow this isn't noticing that we're on macOS and using .dylib instead of .so:

https://github.com/Homebrew/homebrew-core/actions/runs/12293281994/job/34305808506?pr=197800#step:3:1874

This did work testing upstream in in CI via macOS building using Homebrew supplied dependencies building from source:

https://github.com/alerque/sile/actions/runs/12292956425/job/34304658415

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 12, 2024
@alerque alerque force-pushed the sile-0.15.6 branch 5 times, most recently from e1bf3a3 to 9ddd9ff Compare December 14, 2024 12:39
@alerque alerque force-pushed the sile-0.15.6 branch 4 times, most recently from 835911f to 744fd9e Compare December 14, 2024 13:36
@alerque alerque force-pushed the sile-0.15.6 branch 2 times, most recently from e297e6f to bfa3d94 Compare December 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. icu4c ICU use is a significant feature of the PR or issue lua Lua use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant