Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: also write *-apple-macosx* config files #197410

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fixes #197278.

Also, remove the CLT requirement for pouring bottles. Many users use
this for the libraries, which don't need the CLT. We can add it back if
users report getting tripped up by this.

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Nov 12, 2024
@carlocab carlocab requested a review from Bo98 November 12, 2024 04:15
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want macosx#{macos_version} and darwin#{kernel_version}

Formula/l/llvm.rb Outdated Show resolved Hide resolved
Formula/l/llvm.rb Outdated Show resolved Hide resolved
@carlocab
Copy link
Member Author

You'll want macosx#{macos_version} and darwin#{kernel_version}

Will do, thanks. Also, just remembered:

What about *-apple-macos*? I think that's a valid triple too. 🙃

@Bo98
Copy link
Member

Bo98 commented Nov 12, 2024

My upstream patch calls Triple.getOSTypeName which should already normalise that to macosx. Can double check with the built bottle to be sure.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 12, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 12, 2024
Formula/l/llvm.rb Outdated Show resolved Hide resolved
Formula/l/llvm.rb Outdated Show resolved Hide resolved
@carlocab carlocab force-pushed the llvm-macosx-config branch 2 times, most recently from 6c26e27 to 18ad8d4 Compare November 12, 2024 05:19
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Fixes #197278.

Also, remove the CLT requirement for pouring bottles. Many users use
this for the libraries, which don't need the CLT. We can add it back if
users report getting tripped up by this.

Co-authored-by: Bo Anderson <[email protected]>
@carlocab carlocab added long build Set a long timeout for formula testing CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Nov 12, 2024
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 13, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit ffbedad Nov 13, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the llvm-macosx-config branch November 13, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm: Support all -macosx target triples
3 participants