Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lando 2.3.2 new formula alias old lando-cli #196159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

lando 2.3.2 new formula alias old lando-cli #196159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
061f019
lando 2.3.0 new formula alias old lando-cli
reynoldsalec Oct 30, 2024
07a62fa
lando 2.3.2 bump formula
reynoldsalec Oct 30, 2024
2b16cef
lando correct quoting of pkg-ed options.
reynoldsalec Oct 30, 2024
4b50d7d
Merge branch 'master' into lando-2.3.2
reynoldsalec Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Aliases/lando-cli
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../Formula/l/lando.rb
41 changes: 0 additions & 41 deletions Formula/l/lando-cli.rb
View file
Open in desktop

This file was deleted.

33 changes: 33 additions & 0 deletions Formula/l/lando.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
class Lando < Formula
desc "Push button development environments"
homepage "https://docs.lando.dev"
url "https://github.com/lando/core/archive/refs/tags/v3.23.2.tar.gz"
sha256 "a3edf4c1d82ce6af725d9760122f74e8ed74d453140d12407bf5764f19b145d5"
license "GPL-3.0-or-later"

livecheck do
url :stable
regex(/^v?(\d+(?:\.\d+)+)$/i)
end

depends_on "node"

def install
system "npm", "install", "--production", *std_npm_args
system "npm", "add", "@yao-pkg/[email protected]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't download unchecksummed things as part of the build

system "npx", "pkg", "--config", "package.json", "--targets", "node20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more formula is not node 20

"--options", "dns-result-order=ipv4first", "bin/lando"
bin.install "dist/@lando/core" => "lando"
end

def caveats
<<~EOS
To complete the installation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to homebrew? Otherwise it should not be a caveat

lando setup
EOS
end

test do

Check failure on line 30 in Formula/l/lando.rb

View workflow job for this annotation

GitHub Actions / Linux

`brew test --verbose lando` failed on Linux! 

/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test.rb:54:in `<main>'
assert_match "127.0.0.1", shell_output("#{bin}/lando config --path proxyIp")
end
end
Loading