Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythran: migrate to [email protected] #194274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pythran: migrate to [email protected] #194274

wants to merge 1 commit into from
+14 −11

Conversation

chenrui333
Copy link
Member

pythran: migrate to [email protected]

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 13, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Oct 13, 2024
@chenrui333
Copy link
Member Author 

  ==> /opt/homebrew/opt/pythran/bin/pythran -DUSE_XSIMD -fopenmp -march=native /private/tmp/pythran-test-20241013-14245-1xd3lk/arc_distance.py
  clang: error: unsupported option '-fopenmp'
  WARNING: Compilation error, trying hard to find its origin...
  Compilation error, trying hard to find its origin...
  WARNING: Nope, I'm going to flood you with C++ errors!
  Nope, I'm going to flood you with C++ errors!
  CRITICAL: Cover me Jack. Jack? Jaaaaack!!!!
  E: error: command '/usr/bin/clang++' failed with exit code 1
  Cover me Jack. Jack? Jaaaaack!!!!
  E: error: command '/usr/bin/clang++' failed with exit code 1
  Error: pythran: failed
  Error: pythran: failed

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Oct 14, 2024
@chenrui333
pythran: migrate to [email protected]
4cf6bf3 
Signed-off-by: Rui Chen <[email protected]>

pythran: update test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed test failure CI fails while running the test-do block labels Oct 15, 2024
carlocab
carlocab requested changes Oct 15, 2024
View reviewed changes
Formula/p/pythran.rb
Comment on lines -87 to -89
with_env(CC: nil, CXX: nil) do
system pythran, "-DUSE_XSIMD", "-fopenmp", "-march=native", testpath/"arc_distance.py"
end
Copy link
Member

@carlocab carlocab Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't change this. If the test fails with CC and CXX unset then the formula is broken.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now seeing the same in #196198 maybe something not from pythran?

@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Oct 15, 2024
@chenrui333 chenrui333 mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
python Python use is a significant feature of the PR or issue python-3.13-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @carlocab