Restore Gleam, Rebar3 and Erlang LS to erlang
again
#191478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of each of the formulas you're submitting?brew test <formula>
, where<formula>
is the name of each of the formulas you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
) for each of the submitted formulas? If this is a new formula, does it passbrew audit --new <formula>
?... and not specifically bound to a given version (
@26
). It's possible something changed (for the better) since I started working on theerlang@27
formula, but CI will tell if this change is Ok (locally it seems to be).Regarding Erlang LS I also contacted one of the maintainers (@plux), and I'm waiting to understand if
rebar3
is an actual dependency or just a development one, so I'd maybe hold of on merging until I get an answer, after which I'd add=> :build
to the formula.@carlocab, should I up the
revision
here, since I touched the dependencies again?