Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Gleam, Rebar3 and Erlang LS to erlang again #191478

Merged

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Sep 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formulas (all of them) locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of each of the formulas you're submitting?
  • Are your tests running fine brew test <formula>, where <formula> is the name of each of the formulas you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>) for each of the submitted formulas? If this is a new formula, does it pass brew audit --new <formula>?

... and not specifically bound to a given version (@26). It's possible something changed (for the better) since I started working on the erlang@27 formula, but CI will tell if this change is Ok (locally it seems to be).

Regarding Erlang LS I also contacted one of the maintainers (@plux), and I'm waiting to understand if rebar3 is an actual dependency or just a development one, so I'd maybe hold of on merging until I get an answer, after which I'd add => :build to the formula.

@carlocab, should I up the revision here, since I touched the dependencies again?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 21, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 21, 2024
@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review September 21, 2024 22:39
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2024
Merged via the queue into Homebrew:master with commit 151fc6f Sep 21, 2024
15 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the chore/rebar3-erlang branch September 22, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants