Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler: deprecate #191459

Merged
merged 2 commits into from
Sep 21, 2024
Merged

wrangler: deprecate #191459

merged 2 commits into from
Sep 21, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This doesn't seem to build with Erlang 25, 26, or 27 (see #191438).

Upstream also seems to be unresponsive to issues about failed builds, so
let's deprecate it now. To avoid having to change the deprecate! to a
disable! at some future date, let's just set disable! now to a
future date. This will deprecate it today and disable it in the second
half of 2025.

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 21, 2024
@github-actions github-actions bot added the formula disabled Formula disabled label Sep 21, 2024
This doesn't seem to build with Erlang 25, 26, or 27 (see #191438).

Upstream also seems to be unresponsive to issues about failed builds, so
let's deprecate it now. To avoid having to change the `deprecate!` to a
`disable!` at some future date, let's just set `disable!` now to a
future date. This will deprecate it today and disable it in the second
half of 2025.
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Sep 21, 2024
This was referenced Sep 21, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2024
Merged via the queue into master with commit f70f601 Sep 21, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the wrangler-deprecate branch September 21, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula disabled Formula disabled ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants