Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually pass --stable to brew test-bot in the stable tests #182083

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I did a couple of PRs to enable typechecking for taps in brew test-bot. Then the tap_syntax job failed because I forgot about the stable release tag jobs. So I made the typechecking part only run if on HEAD. Then it turns out that this job wasn't actually passing --stable to brew test-bot.

@issyl0 issyl0 requested review from MikeMcQuaid and a team as code owners August 22, 2024 23:56
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Aug 22, 2024
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@p-linnane p-linnane added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit 4bca2f7 Aug 23, 2024
19 checks passed
@p-linnane p-linnane deleted the pass-stable-to-tap-syntax branch August 23, 2024 00:07
@MikeMcQuaid
Copy link
Member

Nice work @issyl0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants