Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.*: remove stale skip_clean #180808

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Related to Homebrew/brew#18002

These do nothing afaict. Only pip3 is still around but that's installed in post_install which happens after cleaning. These originated from 7871f86 way back in 2013 to perserve the writable bit so pip could upgrade itself pip install -U pip.

[email protected] is handled in #180606

@branchvincent branchvincent added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 10, 2024
@github-actions github-actions bot added the legacy Relates to a versioned @ formula label Aug 10, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 11, 2024
Merged via the queue into Homebrew:master with commit 9cf4101 Aug 11, 2024
17 checks passed
@branchvincent branchvincent deleted the python branch August 11, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. legacy Relates to a versioned @ formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants