Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mplayer: work around for 1/4 window bug on Intel macOS #180026

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 5, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fixes #175476

Corresponding code:

#if defined(__aarch64__) || defined(x86_64)
// TODO figure out where this comes from!!
#undef __POWER__
#endif

This comment was marked as outdated.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still bundling FFmpeg?

@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Aug 5, 2024
@cho-m
Copy link
Member Author

cho-m commented Aug 5, 2024

Is this still bundling FFmpeg?

Probably. I never got around to my previous PR on unbundling.


yewtube failure seems to be unrelated as can be reproduced with current bottles. It looks like the code path used ends up running part of yt-dlp that needs ffmpeg installed.

  File "/opt/homebrew/Cellar/yewtube/2.10.5_7/libexec/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 1088, in report_error
    self.trouble(f'{self._format_err("ERROR:", self.Styles.ERROR)} {message}', *args, **kwargs)
  File "/opt/homebrew/Cellar/yewtube/2.10.5_7/libexec/lib/python3.12/site-packages/yt_dlp/YoutubeDL.py", line 1027, in trouble
    raise DownloadError(message, exc_info)
yt_dlp.utils.DownloadError: ERROR: You have requested merging of multiple formats but ffmpeg is not installed. Aborting due to --abort-on-error

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 5, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 06379b2 Aug 5, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the mplayer-fix-intel branch August 5, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mplayer shows movie on a quarter screen only on macOS
4 participants