Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q*: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #179233

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@issyl0 issyl0 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 1, 2024
@github-actions github-actions bot added CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Aug 1, 2024
@chenrui333 chenrui333 removed CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Aug 1, 2024
Formula/q/quictls.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Aug 1, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 1, 2024
@issyl0 issyl0 enabled auto-merge August 1, 2024 15:03
@issyl0 issyl0 added this pull request to the merge queue Aug 1, 2024
@p-linnane p-linnane removed CI-linux-self-hosted Build on Linux self-hosted runner CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner long build Set a long timeout for formula testing labels Aug 1, 2024
Merged via the queue into master with commit a1a81cd Aug 1, 2024
23 checks passed
@issyl0 issyl0 deleted the q-rubocop-no-rmrf branch August 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants