Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamripper: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #179078

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 31, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • Also fix Sorbet error when ENV.cppflags is nil:
Error: An exception occurred within a child process:
    TypeError: Parameter 'newflags': Expected type String, got type NilClass
    Caller: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/s/streamripper.rb:31
    Definition: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/ENV/shared.rb:70 (SharedEnvExtension#append_to_cflags)

This failed to build still in the big PR of s* formulae.

- Also fix Sorbet error when `ENV.cppflags` is nil:

```
Error: An exception occurred within a child process:
    TypeError: Parameter 'newflags': Expected type String, got type NilClass
    Caller: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/s/streamripper.rb:31
    Definition: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/ENV/shared.rb:70 (SharedEnvExtension#append_to_cflags)
```
5a9b84d
@github-actions github-actions bot added the missing license Formula has a missing license which should be added label Jul 31, 2024
@SMillerDev
Copy link
Member

  lib/argv.c:126:7: error: call to undeclared library function 'strcpy' with type 'char *(char *, const char *)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        strcpy (copy[argc], argv[argc]);
        ^
  lib/argv.c:126:7: note: include the header <string.h> or explicitly provide a declaration for 'strcpy'
  1 error generated.

@issyl0 issyl0 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 1, 2024
@issyl0 issyl0 enabled auto-merge August 1, 2024 09:22
@issyl0 issyl0 added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit ec293cf Aug 1, 2024
18 of 24 checks passed
@issyl0 issyl0 deleted the streamripper-rubocop-no-rmrf branch August 1, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. missing license Formula has a missing license which should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants