Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #178914

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@issyl0 issyl0 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles labels Jul 29, 2024
@issyl0
Copy link
Member Author

issyl0 commented Jul 30, 2024

Full audit --formula libgccjit --online --git --skip-style output
  libgccjit
    * Stable: The source URL https://ftp.gnu.org/gnu/gcc/gcc-14.1.0/gcc-14.1.0.tar.xz is not reachable

@issyl0
Copy link
Member Author

issyl0 commented Jul 31, 2024

Installing that formula works for me locally. 🤷🏻 What do we usually do in these situations? It's really only CI syntax, no bottles or anything. Can we add the label and re-run the shorter tests?

@issyl0 issyl0 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 31, 2024
@p-linnane p-linnane enabled auto-merge July 31, 2024 21:08
@p-linnane p-linnane removed CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 31, 2024
@p-linnane p-linnane added this pull request to the merge queue Jul 31, 2024
Merged via the queue into master with commit b115aa7 Jul 31, 2024
25 of 28 checks passed
@p-linnane p-linnane deleted the lib-rubocop-no-rmrf branch July 31, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants