Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t*: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #178798

Merged
merged 10 commits into from
Jul 31, 2024
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@issyl0 issyl0 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles long build Set a long timeout for formula testing labels Jul 28, 2024
@github-actions github-actions bot added CI-linux-self-hosted Build on Linux self-hosted runner CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Jul 28, 2024
@issyl0
Copy link
Member Author

issyl0 commented Jul 30, 2024

truffle test failure:

CONNECTION ERROR: Couldn't connect to node [http://127.0.0.1:50975/.](http://127.0.0.1:50975/)
  Truffle v5.11.5 (core: 5.11.5)
  Node v22.5.1
  Error: truffle: failed
  ::error::truffle: failed
  An exception occurred within a child process:
    BuildError: Failed executing: /usr/local/Cellar/truffle/5.11.5/bin/truffle test

@issyl0 issyl0 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles long build Set a long timeout for formula testing CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Jul 31, 2024
@issyl0 issyl0 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into master with commit 53d2869 Jul 31, 2024
31 of 34 checks passed
@issyl0 issyl0 deleted the t-rubocop-no-rmrf branch July 31, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants