Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b*: Fix Homebrew/NoFileutilsRmrf RuboCop offenses #178145

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@issyl0 issyl0 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles labels Jul 22, 2024
@issyl0 issyl0 force-pushed the two-rubocop-fileutils-rmrf branch from 97569fa to 97c8651 Compare July 24, 2024 20:33
@issyl0
Copy link
Member Author

issyl0 commented Jul 24, 2024

I removed berkeley-db since that was failing to build with unrelated errors - I'll make a new PR for that one to fix it separately.

@p-linnane p-linnane added this pull request to the merge queue Jul 25, 2024
Merged via the queue into master with commit f508893 Jul 25, 2024
29 checks passed
@p-linnane p-linnane deleted the two-rubocop-fileutils-rmrf branch July 25, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants