*formulae: Avoid using rm_rf, rm_f or rmtree

[issyl0]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

• Part of rubocop: Discourage the use of rm_f and rm_rf in formulae and casks brew#17705.

[MikeMcQuaid]

Looks right!

[carlocab]

We should probably be a bit more careful about the ones in post_install blocks, as those will be disruptive to more users.

[fxcoudert]

Two comments:

• rm_f is often used to mean “delete if it exists”, which may cover a difference in linux/macOS build process.
• I don't think this is just style issues, some of these may be breaking changes in formulas. We could bunch them in small batches, but they should be tested imho.

[Bo98]

For formulae, it might be an idea to just change rm_f to mean rm if File.exist?.

We do include FileUtils, but we can easily override that with a def rm_f because the formula API is our API, e.g.

module SafeFileUtils
  include FileUtils

  def rm_f(*)
    ...
  end
end

class Formula
  include SafeFileUtils

  ...
end

Which can be used in brew etc too. Or if we're not comfortable with that: then that flow could be used to odeprecated.

(Not saying we need to do this: just tabling options)

[MikeMcQuaid]

• which may cover a difference in linux/macOS build process.

I think these differences should be covered with if/else instead.

For formulae, it might be an idea to just change rm_f to mean rm if File.exist?.

This would still be a breaking change. I think it'd be nicer to introduce a new method/API if we're going to do that rather than shadowing the FileUtils one.

[issyl0]

I re-generated this after the latest changes to the RuboCop.

[issyl0]

I don't think this is just style issues, some of these may be breaking changes in formulas. We could bunch them in small batches, but they should be tested imho.

Hmmm. I'll bunch these in smaller batches, and test installing and testing each one locally. :-)